fix: staticcheck and deadcode findings repo-wide, modernize counting loops

verify/coverage.go

@@ -55,49 +55,3 @@ func (k *Kernel) BlockCount(name string) (int, error) {
 	}
 	return len(blocks), nil
 }
-
-// PathFingerprint is the observable output of one function execution: the
-// values written back into the result slots of the argument block.  Two
-// executions that produce the same fingerprint took observationally
-// equivalent paths (though they may differ internally).
-type PathFingerprint struct {
-	Results []uint64 // the result words from the arg block
-}
-
-// ProfilePaths runs the function with each of the given argument blocks and
-// collects the distinct output fingerprints.  This measures path diversity:
-// how many observationally different execution paths the input corpus
-// exercises.  Combined with Blocks (the static block count), it gives a
-// lower bound on code coverage.
-func (k *Kernel) ProfilePaths(name string, argSets [][]byte, resultOffsets []int) ([]PathFingerprint, error) {
-	idx, ok := k.funcs[name]
-	if !ok {
-		return nil, fmt.Errorf("verify: function %q not found", name)
-	}
-	fl := k.img.Funcs[idx]
-
-	seen := map[string]bool{}
-	var paths []PathFingerprint
-
-	for _, args := range argSets {
-		if len(args) < fl.Args {
-			return nil, fmt.Errorf("verify: %s: arg block too small", name)
-		}
-		out, err := k.CallFunc(name, args)
-		if err != nil {
-			return nil, err
-		}
-		fp := PathFingerprint{}
-		key := ""
-		for _, off := range resultOffsets {
-			v := GetUint64(out, off)
-			fp.Results = append(fp.Results, v)
-			key += fmt.Sprintf("%016x", v)
-		}
-		if !seen[key] {
-			seen[key] = true
-			paths = append(paths, fp)
-		}
-	}
-	return paths, nil
-}